It's a "patrol jacket". Still part of the British military repertoire, and very stylish, but not quite the sort of thing you could wear to the mall or what have you
Nicholas was honorary colonel of the Scots Greys and is presumably wearing one in that capacity