>>536610423
>That abhorrent dialogue system he made with the magic numbers is legitimately extremely retarded
I agree, but these code reviewers constantly mix up good criticism with tiny nitpicks and use hyperboles to reinforce the latter for content.
>and must be contributing to the slowness of the development.
I think he just burnt out on working on the same project for so long.
Even if he had perfect code, I highly doubt he would have developed it much further.
>>536610642
Some of Coding Jesus's criticisms are out there.
For example, in pic-rel he criticizes Thor for using "magic numbers" and suggests using constructors instead. This was a big deal for him, because even an intern could do it better.
His argument for why it's bad is that you'd have to read the "implementation of the function" to understand what the values do.
However,
1) He can just hover over the method and get the signature in any modern IDE, so that's basically untrue.
2) He would have to declare 20+ different variables for each particle effect, which would create a lot of visual noise when he's fiddling with the numbers of the particle to make it look just right.
When you're playing around with numbers, it's better to have all the variables neatly arranged in a few lines instead of having to check where SpriteHealthArgumentXYZ is in your long list of variables.