>>279903830
>but he doesnt feel fulfilled.
He does. He dies with a smile on his face.
Archer only ever starts to regret his ideal when he spent a literal eternity as a Counter Guardian. That was the mistake.
It's explicitly stated in the VN future Shirou died with no regrets.