It was never a good RPG, mechanically it's just not very good, there's 4 moves and all the non-damage moves are bad
It was strongest second-gen when all the Pokemon designs weren't cringe
It was popular primarily among children due to the social aspect, periphery media (anime, cards, toys, etc.) and Pokemon designs.